Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(logstorage): create batch writer #457

Merged
merged 18 commits into from
Jul 19, 2024
Merged

refactor(logstorage): create batch writer #457

merged 18 commits into from
Jul 19, 2024

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Jul 19, 2024 •
edited
Loading

Logs inserter improvement:

goos: linux
goarch: amd64
cpu: AMD Ryzen 9 5950X 16-Core Processor            
                │   old.txt    │               new.txt               │
                │    sec/op    │   sec/op     vs base                │
InserterLogs-32   18.433m ± 0%   7.858m ± 2%  -57.37% (p=0.000 n=15)

                │    old.txt    │               new.txt                │
                │     B/op      │     B/op      vs base                │
InserterLogs-32   17.064Mi ± 0%   1.501Mi ± 0%  -91.20% (p=0.000 n=15)

                │   old.txt    │               new.txt               │
                │  allocs/op   │  allocs/op   vs base                │
InserterLogs-32   231.68k ± 0%   33.24k ± 0%  -85.65% (p=0.000 n=15)

Traces inserter improvement:

goos: linux
goarch: amd64
cpu: AMD Ryzen 9 5950X 16-Core Processor            
                  │   old.txt    │               new.txt               │
                  │    sec/op    │   sec/op     vs base                │
InserterTraces-32   1375.7µ ± 0%   556.0µ ± 1%  -59.58% (p=0.000 n=15)

                  │    old.txt     │               new.txt                │
                  │      B/op      │     B/op      vs base                │
InserterTraces-32   1145.89Ki ± 0%   28.33Ki ± 0%  -97.53% (p=0.000 n=15)

                  │   old.txt   │              new.txt               │
                  │  allocs/op  │ allocs/op   vs base                │
InserterTraces-32   6983.0 ± 0%   969.0 ± 0%  -86.12% (p=0.000 n=15)

@tdakkota
feat(otelstorage): add Len method to Attrs
a0e7de8
@tdakkota
feat(typedpool): add typed sync.Pool wrapper
f5652b1
@tdakkota
test(lokie2e): add inserter benchmark
b65379e
@tdakkota
refactor(logstorage): create batch writer
102fd87 
```
cpu: AMD Ryzen 9 5950X 16-Core Processor
                │   old.txt    │              new.txt               │
                │    sec/op    │   sec/op     vs base               │
InserterLogs-32   2.915m ± 12%   3.112m ± 6%  +6.76% (p=0.001 n=15)

                │   old.txt    │               new.txt                │
                │     B/op     │     B/op      vs base                │
InserterLogs-32   1.709Mi ± 0%   1.163Mi ± 0%  -31.98% (p=0.000 n=15)

                │   old.txt   │               new.txt               │
                │  allocs/op  │  allocs/op   vs base                │
InserterLogs-32   23.17k ± 0%   16.40k ± 0%  -29.23% (p=0.000 n=15)
```
@tdakkota
perf(chstorage): re-use log inserter columns
6eecac1 
```
cpu: AMD Ryzen 9 5950X 16-Core Processor
                │   old.txt   │               new.txt               │
                │   sec/op    │   sec/op     vs base                │
InserterLogs-32   2.055m ± 1%   1.614m ± 1%  -21.47% (p=0.000 n=15)

                │    old.txt    │               new.txt                │
                │     B/op      │     B/op      vs base                │
InserterLogs-32   1189.9Ki ± 0%   753.6Ki ± 0%  -36.67% (p=0.000 n=15)

                │   old.txt    │               new.txt               │
                │  allocs/op   │  allocs/op   vs base                │
InserterLogs-32   16.393k ± 0%   7.897k ± 0%  -51.83% (p=0.000 n=15)
```
@tdakkota
perf(chstorage): compute column list only once
753e84d 
```
cpu: AMD Ryzen 9 5950X 16-Core Processor
                │   old.txt   │               new.txt               │
                │   sec/op    │   sec/op     vs base                │
InserterLogs-32   16.30m ± 1%   14.32m ± 1%  -12.16% (p=0.000 n=15)

                │   old.txt    │               new.txt                │
                │     B/op     │     B/op      vs base                │
InserterLogs-32   7.333Mi ± 0%   4.301Mi ± 0%  -41.34% (p=0.000 n=15)

                │   old.txt   │              new.txt               │
                │  allocs/op  │  allocs/op   vs base               │
InserterLogs-32   78.96k ± 0%   73.94k ± 0%  -6.36% (p=0.000 n=15)
```
@tdakkota
perf(chstorage): re-use log inserter columns proto.Input
b635ad8 
```
cpu: AMD Ryzen 9 5950X 16-Core Processor
                │   old.txt   │               new.txt               │
                │   sec/op    │   sec/op     vs base                │
InserterLogs-32   14.48m ± 0%   12.17m ± 1%  -15.97% (p=0.000 n=15)

                │   old.txt    │               new.txt                │
                │     B/op     │     B/op      vs base                │
InserterLogs-32   4.301Mi ± 0%   3.013Mi ± 0%  -29.95% (p=0.000 n=15)

                │   old.txt   │               new.txt               │
                │  allocs/op  │  allocs/op   vs base                │
InserterLogs-32   73.94k ± 0%   65.29k ± 0%  -11.70% (p=0.000 n=15)
```
@tdakkota
chore(otelstorage): pre-allocate resulting label
1cb63d8
@tdakkota
test(otelstorage): ensure that Unicode is properly handled
c311fe4
@tdakkota
test(otelstorage): add KeyToLabel benchmark
00f4c17
@tdakkota
perf(otelstorage): optimize replacer
db78d4b 
```
cpu: AMD Ryzen 9 5950X 16-Core Processor
              │   old.txt   │               new.txt               │
              │   sec/op    │   sec/op     vs base                │
KeyToLabel-32   91.50n ± 0%   59.52n ± 1%  -34.95% (p=0.000 n=15)
```
@tdakkota
refactor(xsync): move all sync utilities to xsync
41a1d54
@tdakkota
perf(chstorage): generate insert body only once
154ac12 
```
cpu: AMD Ryzen 9 5950X 16-Core Processor
                │   old.txt    │               new.txt               │
                │    sec/op    │   sec/op     vs base                │
InserterLogs-32   11.644m ± 1%   7.732m ± 1%  -33.60% (p=0.000 n=15)

                │   old.txt    │               new.txt                │
                │     B/op     │     B/op      vs base                │
InserterLogs-32   2.917Mi ± 0%   1.501Mi ± 0%  -48.55% (p=0.000 n=15)

                │   old.txt   │               new.txt               │
                │  allocs/op  │  allocs/op   vs base                │
InserterLogs-32   55.44k ± 0%   33.24k ± 0%  -40.05% (p=0.000 n=15)
```
@tdakkota
test(tempoe2e): add traces insereter benchmark
5ff9560
@tdakkota
refactor(tracestorage): create batch writer
a18c67c 
```
cpu: AMD Ryzen 9 5950X 16-Core Processor
                  │   old.txt    │               new.txt               │
                  │    sec/op    │   sec/op     vs base                │
InserterTraces-32   1386.1µ ± 1%   557.9µ ± 2%  -59.75% (p=0.000 n=15)

                  │    old.txt     │               new.txt                │
                  │      B/op      │     B/op      vs base                │
InserterTraces-32   1145.85Ki ± 0%   56.02Ki ± 0%  -95.11% (p=0.000 n=15)

                  │   old.txt   │               new.txt               │
                  │  allocs/op  │  allocs/op   vs base                │
InserterTraces-32   6.983k ± 0%   1.009k ± 0%  -85.55% (p=0.000 n=15)
```
@tdakkota
perf(otelstorage): increase Attrs on-stack sorting threshold
a249e32 
```
cpu: AMD Ryzen 9 5950X 16-Core Processor
                  │   old.txt   │            new.txt            │
                  │   sec/op    │   sec/op     vs base          │
InserterTraces-32   557.1µ ± 1%   553.5µ ± 1%  ~ (p=0.081 n=15)

                  │   old.txt    │               new.txt                │
                  │     B/op     │     B/op      vs base                │
InserterTraces-32   56.02Ki ± 0%   28.29Ki ± 0%  -49.50% (p=0.000 n=15)

                  │   old.txt   │              new.txt              │
                  │  allocs/op  │ allocs/op   vs base               │
InserterTraces-32   1009.0 ± 0%   969.0 ± 0%  -3.96% (p=0.000 n=15)
```
@tdakkota
fix(otelstorage): replace unicode characters with underscore
1364027
@tdakkota
perf(otelstorage): write converted label right to column
34b4988 
```
cpu: AMD Ryzen 9 5950X 16-Core Processor
                │   old.txt   │              new.txt               │
                │   sec/op    │   sec/op     vs base               │
InserterLogs-32   7.852m ± 1%   7.479m ± 1%  -4.75% (p=0.000 n=15)

                │   old.txt    │               new.txt               │
                │     B/op     │     B/op      vs base               │
InserterLogs-32   1.501Mi ± 0%   1.359Mi ± 0%  -9.44% (p=0.000 n=15)

                │   old.txt   │               new.txt               │
                │  allocs/op  │  allocs/op   vs base                │
InserterLogs-32   33.24k ± 0%   24.63k ± 0%  -25.91% (p=0.000 n=15)
```
@tdakkota tdakkota marked this pull request as ready for review July 19, 2024 08:48
@tdakkota tdakkota merged commit bcbb468 into main Jul 19, 2024
17 checks passed
@tdakkota tdakkota deleted the refactor/inserter branch July 19, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tdakkota