Added more methods from RFC 7519 standard. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DroidZed
changed the title
jwtauth.go
Outdated
Comment on lines
241
to
264
| // Set subject ("sub") in the claims | ||
| func setSub(claims map[string]interface{}, sub string) { | ||
| claims["sub"] = sub | ||
| } | ||
|
|
||
| // Set audience ("aud") in the claims | ||
| func setAudience(claims map[string]interface{}, aud string) { | ||
| claims["aud"] = aud | ||
| } | ||
|
|
||
| // Set JWT ID ("jti") in the claims | ||
| func setJwtId(claims map[string]interface{}, jti string) { | ||
| claims["jti"] = jti | ||
| } | ||
|
|
||
| // Set not Before ("nbf") in the claims | ||
| func setNotBefore(claims map[string]interface{}, nbf time.Time) { | ||
| claims["nbf"] = nbf.UTC().Unix() | ||
| } | ||
|
|
||
| // Add custom additional claim in the claims (For private/public claims, RFC 7519) | ||
| func setXClaim(claims map[string]interface{}, claimName string, claimValue interface{}) { | ||
| claims[claimName] = claimValue | ||
| } |
There was a problem hiding this comment.
Since these new functions are not exported, what's the point of adding it to the codebase?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it kinda annoying to not have a helper method for the other fields found in RFC 7519 registered claims section, even if it's a one liner for each part, I really thought it would be helpful to add these methods and make our lives n lines less painful.