add WithParseOption() to create jwtauth with custom parse options #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could also consider allowing to specify multiple parse-options |
|
@pkieltyka any thoughts on this? |
re-Tick
approved these changes
Mar 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR adds the new function
WithParseOption(), which allows specifying custom parse options forJWTAuth.This enables specifying custom options such as
jwt.WithKeySetProvider, which allows us to use JWKS and more sophisticated validation logic.See also related #59, #40, #27. We should be able to resolve most of the mentioned issues here with these custom options.
Thanks a lot, let me know if you have any further feedback!