Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix condition in TestRedirectSlashes #856

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Fix condition in TestRedirectSlashes #856

merged 2 commits into from
Sep 18, 2024

Conversation

tchssk
Copy link
Contributor

@tchssk tchssk commented Oct 7, 2023

I changed the conditions to make sure that both the response body and status are correct.

@tchssk tchssk marked this pull request as ready for review October 7, 2023 06:40
VojtechVitek
VojtechVitek approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@VojtechVitek VojtechVitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

However, I think we should change t.Fatalf(body) too

  1. body acts as "format"
  2. responseCode is missing

@VojtechVitek VojtechVitek merged commit 7335050 into go-chi:master Sep 18, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VojtechVitek VojtechVitek VojtechVitek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tchssk @VojtechVitek