Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSURLSession fixes and improvements #286

Merged
merged 14 commits into from
Mar 11, 2023
Merged

NSURLSession fixes and improvements #286

merged 14 commits into from
Mar 11, 2023

Commits on Feb 17, 2023

  1. Add missing NSURLSession APIs

    @triplef
    triplef committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    05adcf6 View commit details
    Browse the repository at this point in the history

  2. Fix NSURLSession memory management of libdispatch objects and overrel… 

    …ease in GSHTTPURLProtocol.
    @triplef
    triplef committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    e3c4335 View commit details
    Browse the repository at this point in the history

  3. Fix NSURLSession header fields not always being matched case insensit… 

    …ive.
    @triplef
    triplef committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    cabf3a3 View commit details
    Browse the repository at this point in the history

  4. NSURLSession: optimized timout timer and fixed memory management

    @triplef
    triplef committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    354df2a View commit details
    Browse the repository at this point in the history

  5. NSURLSession: create dispatch queues using target and use lock instea… 

    …d of queue for session identifier

Creating stand-alone dispatch queues without a target is discouraged.
    @triplef
    triplef committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    e753c87 View commit details
    Browse the repository at this point in the history

  6. NSURLSession: call getTasks callbacks on delegate queue 

    Matches the documented behavior.
    @triplef
    triplef committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    719b384 View commit details
    Browse the repository at this point in the history

  7. NSURLSession: use mutable data for transfer state body

    @triplef
    triplef committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    54e0914 View commit details
    Browse the repository at this point in the history

  8. NSURLSession: implement missing body data for data completion handlers 

    Now using the previously unused "in-memory" body data drain if a task has a completion handler, which requires the full body to be passed on completion.

Also consolidated private NSURLSessionTask methods, some of which were previously implemented twice in separate categories with the same name, leading to possible undefined runtime behavior.
    @triplef
    triplef committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    8303a72 View commit details
    Browse the repository at this point in the history

  9. NSURLSession: improve protocol detection

    @triplef
    triplef committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    2117a63 View commit details
    Browse the repository at this point in the history

  10. NSURLSession: fix libcurl debug output

    @triplef
    triplef committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    ba0c1e1 View commit details
    Browse the repository at this point in the history

  11. NSURLSession: fix memory management in GSTransferState

    @triplef
    triplef committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    792b027 View commit details
    Browse the repository at this point in the history

  12. NSURLSession: mark broken test as hopeful on Windows

    @triplef
    triplef committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    6e1d53d View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. CI: add tools-make/tools-windows-msvc branch name to run name

    @triplef
    triplef committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    1b5117f View commit details
    Browse the repository at this point in the history

  2. CI: fix MSVC builds when building dependencies

    @triplef
    triplef committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    cb7e82e View commit details
    Browse the repository at this point in the history