Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller memory imprint of semicompiled code #1687

Conversation

GillesDuvert
Copy link
Contributor

Important evolution of previous PR #1681
It was found

  1. that the memory imprint of the semi-compiled code could be made much smaller, and
  2. that the size of save,/routine files that contained pro/fun issued from files with a large number of entries (e.g., atv.pro that contains all related routines needed) would erroneously duplicated many times the semi-compiled code.
    With the present setup, the size of the save file is approx twice the size of the corresponding .pro file, and the memory imprint negligible.

…memory, to be written as minimally as possible in the save file.

A serie of tricks will be used, noticeably to limit the size of some entries that do not deserve to be int32 or int64 (ex: line number, can it be larger than a ushort = 65535 !)
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 83 lines in your changes are missing coverage. Please review.

Comparison is base (7742324) 41.95% compared to head (d746672) 41.96%.

Files Patch % Lines
src/saverestore.cpp 60.54% 73 Missing ⚠️
src/dpro.cpp 87.30% 8 Missing ⚠️
src/gdlhelp.cpp 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1687      +/-   ##
==========================================
+ Coverage   41.95%   41.96%   +0.01%     
==========================================
  Files         356      356              
  Lines       95597    95606       +9     
  Branches    19662    19656       -6     
==========================================
+ Hits        40103    40123      +20     
+ Misses      55494    55483      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GillesDuvert GillesDuvert merged commit 44a497b into gnudatalanguage:master Dec 14, 2023
7 of 8 checks passed
@GillesDuvert GillesDuvert deleted the smaller_memory_imprint_of_semicompiled_code branch July 2, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant