New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Cycle Detection to Ignore Direct Recursion #44

Merged

notJoon merged 1 commit into main from ignore-recursion-when-cycle-detection

Aug 1, 2024

Contributor

notJoon commented Aug 1, 2024 •

edited

Loading

Description

Modified analyzeFuncDecl:
- Ignores self-calls when building the dependency graph.
- This prevents direct recursion from being mistaken for a cycle.
Update dfs:
- Added a check to ignore direct self-reference during cycle delection.

Still correctly identifies indirect cycles (e.g., A -> B -> A).


          fix: Cycle Detection to Ignore Direct Recursion

e2c7c2a

notJoon added the bug label

notJoon merged commit 3843478 into main

3 checks passed

notJoon deleted the ignore-recursion-when-cycle-detection branch

August 1, 2024 03:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug