Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notes to warning logs #371

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add notes to warning logs #371

wants to merge 2 commits into from

Conversation

Ghoulboy78
Copy link
Collaborator

Cos otherwise reading through logs can be a bit confusing if you don't know what you're looking for

@Ghoulboy78
Add notes to warning logs
c5aef90 
Cos otherwise reading through logs can be a bit confusing if you don't know what you're looking for
@Ghoulboy78 Ghoulboy78 added the app-update Updates an app label Apr 15, 2023
@Ghoulboy78 Ghoulboy78 marked this pull request as ready for review April 15, 2023 10:10
rv3r
rv3r approved these changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@rv3r rv3r left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm not really in a position to test it. It'll probably be fine. It works and makes it easier to find these messages. Should this script prefix get added to line 40 as well?

@Ghoulboy78
Copy link
Collaborator Author

Good call, completely missed that one

rv3r
rv3r approved these changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@rv3r rv3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rv3r rv3r rv3r approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
app-update Updates an app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ghoulboy78 @rv3r