Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arrow restocking #357

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add arrow restocking #357

wants to merge 3 commits into from

Conversation

rv3r
Copy link
Collaborator

@rv3r rv3r commented Jan 30, 2023

Fixes #255 by saving arrow slot on bow or crossbow use and checking for slot change when bow or crossbow is released. Also updated comments to reflect this change and cleaned up spacing from #353.

Apparently I use global variables to solve my problems...

This can restock a bow and arrows in a single use (just don't try to get a bow from a keep box). It also easily restocks tipped arrows correctly because they use the same NBT tag for potion effect as regular potions. I tip my hat to whoever did that.

Fixes #255 by saving arrow slot and checking for slot change when bow or crossbow is released.
Also updated comments to reflect this change and cleaned up spacing from #353.
Apparently I use global variables to solve my problems...
@rv3r rv3r marked this pull request as draft February 5, 2023 02:49
@rv3r
Copy link
Collaborator Author

rv3r commented Feb 5, 2023

Marked as draft since there are some errors I just found. Will fix next week tomorrow.

@rv3r rv3r self-assigned this Feb 5, 2023
@rv3r rv3r marked this pull request as ready for review February 5, 2023 15:08
@rv3r
Copy link
Collaborator Author

rv3r commented Feb 5, 2023

Also, are we okay with this script not restocking fireworks for crossbows? I can do that, but while it isn't exactly what the issue mentioned, it's a similar idea.

@rv3r rv3r requested a review from Ghoulboy78 February 16, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] making shulkers.sc restock arrows
2 participants