Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graves: Inspired by Universal Graves #336

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

pseudofractal
Copy link

Its almost an 1 to 1 copy of Universal Graves mod except the fancy holograms and some minor stuff. Since this uses fake screens, the minimum carpet version is bumped up to 1.4.57.

Spent a lot of time trying to make things as user friendly as possible. I am not very happy with the stuff I am doing to find a "safe" grave location, but I think the current solution is the best until #311.

Another thing, I am using player Name in all places instead of uuid because I did not find any good way of fetching the uuid from a name (Player heads store the player name and not uuid in their block data and Mojang api is rate limited)

Another another thing, I am using both set() and run('setblock') in different places. The reason for this is, set sometimes fails (particularly when replacing a player head) I need to do some more tests and then make a issue regarding this.

@altrisi altrisi added the new-app About adding a new app label Jul 30, 2022
Gave the script to a server to play around with (Thanks kris)

Made some changes to message formatting
Made lots of changes, implemented a CLI based settings system to simplify editing config.
Replaced a lot of one-time use methods with lambdas.
Copy link
Collaborator

@Ghoulboy78 Ghoulboy78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is some feedback, plus the code required to move to store_app_data. It may a be a bit of work, but honestly I think it's an improvement over saving 2 json files over and over again in the code.

programs/survival/graves.sc Outdated Show resolved Hide resolved
programs/survival/graves.sc Outdated Show resolved Hide resolved
programs/survival/graves.sc Outdated Show resolved Hide resolved
Implemented the file related recommendations from discord, settings and gdata are now stored in same file. With my limited testing this does work fine. Also fixed some typos and minor aesthetic changes,etc.
Forgot to change that link
@altrisi
Copy link
Collaborator

altrisi commented Oct 16, 2022

Found an issue, if you drown the head will pop, and bye items.

@altrisi
Copy link
Collaborator

altrisi commented Oct 16, 2022

Also curious what determines if the inventory will be restored directly or if the screen will open?

@altrisi
Copy link
Collaborator

altrisi commented Oct 16, 2022

Found an issue, if you drown the head will pop, and bye items.

Actually, the head will keep some grave data, so if you place it and right click/break it it will disappear, but the items won't be restored.

@pseudofractal
Copy link
Author

Also curious what determines if the inventory will be restored directly or if the screen will open?

Well two things.

  1. If the clicker is the grave owner, then it will try to shift all items directly to inventory and try to maintain positions of items. If its someone else, then they get the screen.
  2. While trying to shift items, if the inventory already contains some item in slot x, then it will open the screen.

@pseudofractal
Copy link
Author

Found an issue, if you drown the head will pop, and bye items.

Ahh I never tried drowning but it does make sense. The debug command would fix this but a better solution is needed yh....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-app About adding a new app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants