Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added IceWolf23's apps #365

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Added IceWolf23's apps #365

wants to merge 7 commits into from

Conversation

Ghoulboy78
Copy link
Collaborator

Fixes #338, Fixes #339

I added the suggestions as they were in the issues, with only a couple modifications, like using newer scarpet syntax, or using a set instead of a list in elytra_swap.sc

@Ghoulboy78
Copy link
Collaborator Author

@IceWolf23 Idk how to directly request your review through the github buttons, but could you pls review?

rv3r
rv3r approved these changes Feb 12, 2023
View reviewed changes
Copy link
Collaborator

@rv3r rv3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admittedly I was waiting on approval from the original author before reviewing, but I didn't tell you that. My bad.

Apps work as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rv3r rv3r rv3r approved these changes

@IceWolf23 IceWolf23 IceWolf23 approved these changes

@altrisi altrisi Awaiting requested review from altrisi

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elytra Swap Mob Display Health
3 participants
@Ghoulboy78 @rv3r @IceWolf23