Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and improve #1900

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Cleanup and improve #1900

wants to merge 11 commits into from

Conversation

extclp
Copy link

@extclp extclp commented Apr 24, 2024

No description provided.

@altrisi
Copy link
Collaborator

altrisi commented Apr 28, 2024

Many of those here are just a different style, and some are simply wrong (replacing Collectors.toList() with Stream.toList(), the ones where that could be done I already did, Stream.toList() is immutable, and others).

getLast is nice, tho I don't think getFirst is necessarily that much better. Much noise for little reward, actually longer.

I may take a closer look when I have some more time and take the parts that make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants