-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some planned screen anvancement and let functions of screen support crafter. #1833
Draft
17183248569
wants to merge
22
commits into
gnembon:master
Choose a base branch
from
19564231242:screen
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 2 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
19ca5a2
temp step
17183248569 2ca7f37
event
17183248569 414a8a5
reslove replaceitem s comment
17183248569 fdc5933
let opening inv fires the event too
17183248569 aae7989
add a type there....
17183248569 a72e8e8
not good...
17183248569 a7c3a2c
for special cases...
17183248569 9632ccd
why not give it a try?
17183248569 c7b87b1
reduce some unnecessary code
17183248569 d905493
Merge remote-tracking branch 'upstream/master' into screen
17183248569 ff8fc87
Merge remote-tracking branch 'upstream/master' into screen
17183248569 3c35adf
try to support crafter
17183248569 7e9b8bf
Merge remote-tracking branch 'upstream/master' into screen
17183248569 280baf8
Merge remote-tracking branch 'upstream/master' into screen
17183248569 ff4f72f
Merge remote-tracking branch 'upstream/master' into screen
17183248569 f45cd0d
small tweak
17183248569 3de14ed
return "horse" when it is horse...
17183248569 2141d1d
Merge remote-tracking branch 'upstream/master' into screen
17183248569 9d1b12e
small change....:thinking:
17183248569 dbb30fe
Still slightly different from the real thing.
17183248569 0faf2bd
make it more similar to the real one....
17183248569 5951a5e
small rename
17183248569 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not use a map, since you aren't gonna know whether a screen will ever be retrieved from
get_current_screen
at all. It just creates additional overhead, that would be required even if no scripts are running. Setting it to null and returning a null value when querying name is probably the best option IMO.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. i let it be null now.