Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix-fake-player-xp-not-resetting-on-death #1800

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix-fake-player-xp-not-resetting-on-death #1800

wants to merge 2 commits into from

Conversation

silnarm
Copy link
Contributor

@silnarm silnarm commented Aug 12, 2023

James103
James103 reviewed Aug 13, 2023
View reviewed changes
src/main/java/carpet/patches/EntityPlayerMPFake.java Outdated
@@ -187,6 +187,7 @@ public void die(DamageSource cause)
shakeOff();
super.die(cause);
setHealth(20);
giveExperienceLevels(-(experienceLevel + 1));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line, which removes all levels and XP, should be wrapped in a check that /gamerule keepInventory is false.

@silnarm
fix-fake-player-xp-not-resetting-on-death
71b8eae 
* only remove XP if not KEEPINVENTORY
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@James103 James103 James103 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fake Players do not lose their XP when dying and still drop XP orbs
2 participants
@silnarm @James103