Added 'item_cooldown' to query and modify item cooldowns #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To mixin you can use a string |
|
How so? |
|
Wait, I might have found a solution |
|
Or maybe targets |
|
If that's not enough then there's accesswidener |
|
I've tried that and I've tried accesswidener, neither seems to be able to work. |
|
Note that after accesswidener you have to regenerate/reimport/sync/refresh (or whatever it's called on intellij gradle) the minecraft sources/the project given it modifies directly the game jar. |
Doesn't work tho for some reason
I have genuinely no idea what I did, but it works now, and I'm not gonna mess with it.
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #597
Simple fix, but querying item cooldowns only returns a percentage. I'd like to make it return the number of ticks, but there are private classes involved (specifically
net.minecraft.world.item.ItemCooldowns.CooldownInstance), which idk how to mix into.