Simplify and fix some issues in /script
command registration
#1751
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
/script
command registration a bit, mostly to make it more clear when adding to brigadier and to fix some issues with it.Summary of changes:
/script in <app>
will no longer silently use the default host whenapp
isn't valid, but instead will fail/script
actions such asstop
orresume
will no longer be repeated under each/script in <app>
/script download
if app store is completely disabled/script
is under the same ruleStream
->List
conversions for some suggestionsThere may be more changes I've missed given most of this has been in a git stash for a while, though I think I got them all.