Refactor Frontend Code and Fix Cryo-EM issue #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorganized the code structure by renaming and relocating several components to their appropriate directories for better code readability and maintainability. Furthermore, the visualization tool, Moorhen, was enhanced by appending the pdbCode to its URL, improving its functionality by directly visualizing specific structures.
The fetch_from_pdb function now returns an explicit Promise rejection when an error occurs. Before, the function was catching errors but not handling them. This change leads to more meaningful error message and overall improved error handling.
The useState for tableData in Home.tsx has been changed from TableDataEntry[] to ResultsEntry[]. This change is based on the modification of the data being stored in the state. It will ensure the correct type is used for easier future development and reduce runtime type errors.
The structure reading function now provides more detailed output for improved debug clarity. In addition, cell size is verified before gemmi molecule creation. Specifically, if the cell size is 1x1x1 units, it is inflated to 300x300x300 units.
This commit is focused around proper error handling. In fetch_from_pdb.ts, the catch block of the Promise has been modified to return a rejected Promise with the actual error object instead of a static string. This provides more detailed and dynamic error information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the location of files in the frontend to make more sense with the current scope of the project. In addition, the necessary backend changes to allow the web app to work with cryo-em data has been made.
Changes