Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Started adding support for image subsets #94

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

astrofrog
Copy link
Member

@Carifio24 this should fix the error you were seeing and adds support for showing subsets for images in WWT:

Screenshot 2023-02-16 145411

How the subsets are rendered is not great as we shouldn't be using colormaps but rather single colors, but this might require some changes in PyWWT to make this possible? We could also use fake colormaps.

cc-ing @pkgw for the PyWWT aspect.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Attention: Patch coverage is 83.78378% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 75.90%. Comparing base (a7a015c) to head (8be5ccf).
Report is 5 commits behind head on main.

Files Patch % Lines
glue_wwt/viewer/image_layer.py 66.66% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   69.04%   75.90%   +6.86%     
==========================================
  Files          18       18              
  Lines        1024     1050      +26     
==========================================
+ Hits          707      797      +90     
+ Misses        317      253      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant