Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checks for old pywwt versions #109

Merged
merged 1 commit into from
May 13, 2024

Conversation

Carifio24
Copy link
Member

This PR resolves #107 by removing all of the old checks for pywwt versions. The last version that was referenced in any of this logic was 0.15, but we're now requiring 0.21.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.19%. Comparing base (ebc522b) to head (a871957).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   69.07%   69.19%   +0.11%     
==========================================
  Files          18       18              
  Lines        1025     1003      -22     
==========================================
- Hits          708      694      -14     
+ Misses        317      309       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Carifio24
Copy link
Member Author

CI failures on macOS look unrelated - some sort of issue with symlinking 2to3?

@Carifio24 Carifio24 requested a review from astrofrog May 9, 2024 19:14
@astrofrog astrofrog merged commit d52016e into glue-viz:main May 13, 2024
16 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove old/unused code in table_layer.py
2 participants