Add entry points for viewer registry #411
Conversation
| def setup(): | ||
| from viewer import BqplotHistogramView # noqa |
There was a problem hiding this comment.
I don't think this is needed, since * is already imported
There was a problem hiding this comment.
Thanks. I think I got confused because I forgot that you have to manually rerun pip install to rebuild the entry points when I was developing this. And yes, this means we can simplify glue-solara to just build a list of viewers from the registry.
|
|
||
|
|
||
| def setup(): | ||
| pass |
There was a problem hiding this comment.
Ideally the setup function should actually be adding the viewer to the registry (rather than using the decorator) - @CyclingNinja is working on improvements to load_plugins that means that users will be able to opt-in to specific plugins, so we need the viewer to not be added if the entry point is not called.
| histogram = glue_jupyter.bqplot.histogram:setup | ||
| image = glue_jupyter.bqplot.image:setup | ||
| profile = glue_jupyter.bqplot.profile:setup | ||
| scatter = glue_jupyter.bqplot.scatter:setup |
There was a problem hiding this comment.
These plugin names might conflict with the ones from glue-core - the entry point names should be unique across the glue ecosystem.
| @@ -7,6 +9,7 @@ | |||
| __all__ = ['IpyvolumeScatterView'] | |||
|
|
|||
|
|
|||
| @viewer_registry("scatter3d") | |||
There was a problem hiding this comment.
The registration of the viewer should be done in setup as mentioned above.
Populate viewer registry for all viewers
Description
This uses entry points to register all the viewers for glue-jupyter into viewer_registry. This addresses #388 and makes all viewers accessible through the
new_data_viewer()command in glue-jupyter. I think this should be compatible with #402, because the viewer registry won't double-populate the same viewers. I have addedIpyvolumeScatterViewasscatter3d.Adding an entry point for glue-wwt will be a separate PR in that repository.
Not 100% about the names here. 'image' is a convenient name for calling in code, but is less descriptive than something like '2d image'. This is particularly relevant for 'scatter' (unqualified) versus 'scatter3d'.