Merge pull request #56 from Carifio24/default-parameters

Update default values for export options
glue-viz · Sep 19, 2024 · 0294cad · 0294cad
2 parents 35c7112 + 740430f
commit 0294cad
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/glue_ar/common/scatter_export_options.py b/glue_ar/common/scatter_export_options.py
@@ -7,8 +7,8 @@
 
 class ARVispyScatterExportOptions(State):
 
-    theta_resolution = CallbackProperty(8)
-    phi_resolution = CallbackProperty(8)
+    theta_resolution = CallbackProperty(10)
+    phi_resolution = CallbackProperty(10)
 
 
 class ARIpyvolumeScatterExportOptions(State):

diff --git a/glue_ar/common/volume_export_options.py b/glue_ar/common/volume_export_options.py
@@ -10,5 +10,5 @@ class ARIsosurfaceExportOptions(State):
 
 
 class ARVoxelExportOptions(State):
-    opacity_cutoff = CallbackProperty(0.05)
-    opacity_resolution = CallbackProperty(0.01)
+    opacity_cutoff = CallbackProperty(0.1)
+    opacity_resolution = CallbackProperty(0.02)
diff --git a/glue_ar/qt/tests/test_tool_scatter.py b/glue_ar/qt/tests/test_tool_scatter.py
@@ -91,5 +91,5 @@ def test_tool_export_call(self, extension, compression):
                 assert len(value) == 2
                 assert value[0] == "Scatter"
                 assert isinstance(value[1], ARVispyScatterExportOptions)
-                assert value[1].theta_resolution == 8
-                assert value[1].phi_resolution == 8
+                assert value[1].theta_resolution == 10
+                assert value[1].phi_resolution == 10
diff --git a/glue_ar/qt/tests/test_tool_volume.py b/glue_ar/qt/tests/test_tool_volume.py
@@ -96,8 +96,8 @@ def test_tool_export_call(self, extension, compression):
             scatter_method, scatter_state = state_dict["Scatter Data"]
             assert scatter_method == "Scatter"
             assert isinstance(scatter_state, ARVispyScatterExportOptions)
-            assert scatter_state.theta_resolution == 8
-            assert scatter_state.phi_resolution == 8
+            assert scatter_state.theta_resolution == 10
+            assert scatter_state.phi_resolution == 10
 
             volume_method, volume_state = state_dict["Volume Data"]
             assert volume_method == "Isosurface"