Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(Framework): Add new hook (pre/post_item_accordion_section) #17860

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

stonebuzz
Copy link
Contributor

@stonebuzz stonebuzz commented Sep 16, 2024

Checklist before requesting a review

Please delete options that are not relevant.

Description

Add new hook

  • pre_item_accordion_section
  • post_item_accordion_section

an example of implementation has been made on the example plugin

pluginsGLPI/example#62

Screenshots (if appropriate):

image

@stonebuzz stonebuzz requested review from orthagh, AdrienClairembault and cedric-anne and removed request for orthagh September 16, 2024 14:16
@stonebuzz stonebuzz self-assigned this Sep 16, 2024
@stonebuzz stonebuzz added this to the 11.0.0 milestone Sep 16, 2024
@cconard96
Copy link
Contributor

Hook name should probably change to indicate it is for ITIL info panel sections, not a generic hook for any accordion sections.
For example: pre/post_itil_info_section

@cedric-anne cedric-anne merged commit 95c5b8a into glpi-project:main Sep 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants