Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit groups with >1 operation in status check. #548

Closed
wants to merge 1 commit into from

Conversation

bdice
Copy link
Member

@bdice bdice commented Jun 27, 2021

Description

While looking into #547 and discussing with @b-butler, I found out that the refactors of the status code from #417 might have broken group status updates.

Here's the output I get with these changes on commit bbeabe1 (compare with output in #547, which does not show band_path_group or dos_group).
image

Motivation and Context

Partially fixes #547.

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

If necessary:

  • I have updated the API documentation as part of the package doc-strings.
  • I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
  • I have updated the changelog.

@bdice bdice requested a review from b-butler June 27, 2021 17:32
@bdice bdice added cluster submission Enhancements to the submission process groups labels Jun 27, 2021
@b-butler
Copy link
Member

Status tests are failing and need to be fixed. Also, is this PR planning on implementing any decisions from #547?

@bdice
Copy link
Member Author

bdice commented Jun 28, 2021

Status tests are failing and need to be fixed. Also, is this PR planning on implementing any decisions from #547?

@b-butler Both of those reasons are why this is still a draft. I just tagged you as a reviewer so you could see what I meant from our Slack conversation. I am going to wait until #547 has more consensus to work on this further, but this draft PR fixed my immediate need for group status information.

@mikemhenry mikemhenry closed this Sep 27, 2021
@bdice
Copy link
Member Author

bdice commented Sep 27, 2021

Closing -- this prototype design is not as good as what we proposed in #547 (comment).

@joaander joaander deleted the fix/group-status branch February 2, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster submission Enhancements to the submission process groups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add groups in status output
3 participants