-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add groups in status output #547
Comments
Maybe the status output should only show groups. I've argued before that operations are in essence just groups of size 1. I think internally we still need to treat operations as first-class entities, but for the status view, everything could be a group? |
@csadorf I like the idea in principle, but I think that only showing groups would be confusing to users. Since every operation has its singleton group, the operations would seem to be there regardless (as they are properly groups). However, when submitting through a user created group, they would show as unsubmitted, but would not be eligible for submission with the only indication of their status being the status of the composing group. That may be fine since multi-operation groups are an opt-in feature, but we would just need to be very clear in our documentation. I would also potentially want more distinction from singleton operations and user/multi-operation groups since in this case I am in favor of @bdice's solution with an additional heading/separation for user groups (even though semantically multi-operation groups are not different from single operation groups) |
@b-butler I see your point and I see why it might be necessary to differentiate individual operations regardless of their group associations. That said, I will keep pushing towards what I consider "conceptual elegance", but I agree that there simply is a subtle difference between operations and singleton groups and trying to ignore that might create more confusion after all. |
I've tried to come up with something, but had enormous trouble in doing so. Do you have a good example workflow (state) that we could all work off from? |
@csadorf I copy-pasted a status output from another project and manually modified it in a text editor to have different operation names and statuses. I was thinking of this as more of a whiteboard sketch, just to understand what kinds of output you’d want to see and how it compares to the example I posted at the top of this issue. 😊 I made up a “state” that I described in the top post:
|
@csadorf Would having a So, something like,
by default, and
with the groups flag. I think this avoids conceptual ambiguity while also providing the user the information necessary. |
Another option discussed with @atravitz and @b-butler during office hours. We like this because it gives more info by default.
|
The current plan is to go with the proposal in the last comment. The first column will be renamed to |
Resolved by #593 |
Feature description
I submitted groups containing multiple operations, but the status output does not reflect this. It appears that groups are currently not integrated with the status output code, resulting in unknown
[U]
status codes even when the operations are contained in actively running groups. (See screenshot.)Proposed solution
Perhaps we need another status code for operations like
[GA]
for "group active" or[GQ]
for "group queued." We could also add a separate line in the status output for each group present in the project. I think it might even make sense to do both, so that it would look like this. Assumemy_group
containsmy_operation1
andmy_operation2
. 10 jobs were submitted asmy_group
, 5 of which are queued and 5 of which are running.Additional context
Related to #469.
The text was updated successfully, but these errors were encountered: