Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruff for code style checks. #112

Merged
merged 10 commits into from
Nov 27, 2023
Merged

Use ruff for code style checks. #112

merged 10 commits into from
Nov 27, 2023

Conversation

joaander
Copy link
Member

@joaander joaander commented Nov 21, 2023

Description

  • Use ruff to perform more code style checks in less time with a simpler pre-commit configuration.
  • Make changes to the code so that all enabled ruff checks pass.

A future pull request will use ruff for formatting as well. The PRs are separate to separate the review of the fixes for checks separately from the fixes that come from the auto-formatter.

Checklist:

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@joaander joaander marked this pull request as ready for review November 22, 2023 12:35
@joaander joaander requested review from a team, tcmoore3, tommy-waltmann and melodyyzh and removed request for a team November 22, 2023 12:35
@joaander joaander changed the title Use ruff for formatting checks. Use ruff for code style checks. Nov 22, 2023
Copy link

@melodyyzh melodyyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. I have one question regarding the output format in the 04-Custom-Actions-In-Python/04-Custom-Updater.ipynb notebook. When output the KE, PE, and total E, there's a gap between the output values and the top of the cell, I am not sure if that is just a display issue in reviewnb.

@joaander
Copy link
Member Author

Everything looks good to me. I have one question regarding the output format in the 04-Custom-Actions-In-Python/04-Custom-Updater.ipynb notebook. When output the KE, PE, and total E, there's a gap between the output values and the top of the cell, I am not sure if that is just a display issue in reviewnb.

@melodyyzh the output appears correct in Jupyter. ReviewNB is adding the empty line.

@joaander joaander merged commit 1b6ce97 into trunk Nov 27, 2023
2 checks passed
@joaander joaander deleted the ruff-check branch November 27, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants