-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ruff for code style checks. #112
Conversation
Apply changes so that 00-Introducing-HOOMD-blue passes ruff check.
Make changes to pass ruff checks in 01-Introducing-Molecular-Dynamics.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me. I have one question regarding the output format in the 04-Custom-Actions-In-Python/04-Custom-Updater.ipynb
notebook. When output the KE, PE, and total E, there's a gap between the output values and the top of the cell, I am not sure if that is just a display issue in reviewnb.
@melodyyzh the output appears correct in Jupyter. ReviewNB is adding the empty line. |
Description
A future pull request will use ruff for formatting as well. The PRs are separate to separate the review of the fixes for checks separately from the fixes that come from the auto-formatter.
Checklist: