Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to match glotzerlab software suite #24

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

janbridley
Copy link
Contributor

@janbridley janbridley commented Jul 23, 2024

Description

CI was updated to use uv. Dependency minimum requirements were removed in favor of compiled pipfiles. It seems like numba interacts with pytest-xdist in unexpected ways, so the two are incompatible.

Have you (if appropriate)

  • Updated changelog
  • Updated Documentation
  • Add tests
  • Added name to contributors

@janbridley janbridley marked this pull request as ready for review July 23, 2024 14:56
@janbridley janbridley requested a review from a team July 23, 2024 14:56
@DomFijan
Copy link
Collaborator

I'll look at this when I get back from FOMMS.

Comment on lines +1 to +9
bottleneck
freud-analysis
kneed
numba
numpy
ruptures
scikit-learn
pandas
xarray
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't these have lowest supported version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably - I will find the lowest variants for each.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably reuse some of the old ones?

.github/workflows/run-pytest.yml Show resolved Hide resolved
Comment on lines +1 to +3
pytest
hypothesis
coverage
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably need lowest supported versions here OR probably would be good to pin these as well? What do you think?

Also do we need coverage? We don't seem to be using it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably use coverage, I'll add that tomorrow. Pins are set in the pipfiles to ensure there are no user-facing hard pins. This can yield unresolvable environments fairly easily

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should set some minimal version in that case?

.github/workflows/run-pytest.yml Show resolved Hide resolved
.github/workflows/run-pytest.yml Outdated Show resolved Hide resolved
@janbridley janbridley enabled auto-merge October 14, 2024 15:55
Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good.

Do you want to add [update-uv-lockfiles][https://github.com/glotzerlab/workflows?tab=readme-ov-file#update-uv-lockfiles] to automatically bump the requirementsX.Y files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants