-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI to match glotzerlab software suite #24
base: main
Are you sure you want to change the base?
Conversation
I'll look at this when I get back from FOMMS. |
bottleneck | ||
freud-analysis | ||
kneed | ||
numba | ||
numpy | ||
ruptures | ||
scikit-learn | ||
pandas | ||
xarray |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't these have lowest supported version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably - I will find the lowest variants for each.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can probably reuse some of the old ones?
pytest | ||
hypothesis | ||
coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably need lowest supported versions here OR probably would be good to pin these as well? What do you think?
Also do we need coverage? We don't seem to be using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably use coverage, I'll add that tomorrow. Pins are set in the pipfiles to ensure there are no user-facing hard pins. This can yield unresolvable environments fairly easily
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should set some minimal version in that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good.
Do you want to add [update-uv-lockfiles
][https://github.com/glotzerlab/workflows?tab=readme-ov-file#update-uv-lockfiles] to automatically bump the requirementsX.Y files?
Description
CI was updated to use
uv
. Dependency minimum requirements were removed in favor of compiled pipfiles. It seems like numba interacts withpytest-xdist
in unexpected ways, so the two are incompatible.Have you (if appropriate)