gh-398: consistent plotting for notebooks #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddyroddy
added
documentation
Saransh-cpp
reviewed
Nov 15, 2024
Comment on lines
+46
to
+48
| "# set up matplotlib to produce consistent figures\n", | ||
| "mpl.rc_file(pathlib.Path.cwd().parents[1] / \".matplotlibrc\")\n", | ||
| "\n", |
There was a problem hiding this comment.
I though it automatically picks up the config from the config file in the current working directory? Is something like that not possible?
There was a problem hiding this comment.
From what I've read it has to be maplotlibrc (i.e. without the dot). Plus, we have notebooks in two different subfolders, so I think it's safer to force load.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #398. Adds a
.matplotlibrcto stabilise the production of plots. For more detail on the config file, look at https://matplotlib.org/stable/users/explain/customizing.html#the-matplotlibrc-file. I haven't used a stylesheet (plt.style.use), as (except forclassic) they don't define the resolution etc. https://github.com/matplotlib/matplotlib/tree/main/lib/matplotlib/mpl-data/stylelib.I did run the notebooks, but they must be using these current values.