Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overload typing to from_convergence #386

Open
paddyroddy opened this issue Oct 25, 2024 · 1 comment · May be fixed by #395
Open

Add overload typing to from_convergence #386

paddyroddy opened this issue Oct 25, 2024 · 1 comment · May be fixed by #395
Assignees
@paddyroddy
Labels
enhancement New feature or request typing Static typing

Comments

@paddyroddy
Copy link
Member

Perhaps a good question to answer first is whether the documentation of from_convergence() can be made human-readable using a number of @typing.overload?

Originally posted by @ntessore in #375
@paddyroddy paddyroddy added enhancement New feature or request typing Static typing labels Oct 25, 2024
@paddyroddy paddyroddy self-assigned this Oct 25, 2024
This was referenced Oct 28, 2024
Merged
Open
@paddyroddy paddyroddy linked a pull request Nov 1, 2024 that will close this issue
gh-368: add type overloading for lensing.from_convergence #395
Open
@paddyroddy
Copy link
Member Author

https://adamj.eu/tech/2021/05/29/python-type-hints-how-to-use-overload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paddyroddy paddyroddy

Labels
enhancement New feature or request typing Static typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-368: add type overloading for lensing.from_convergence glass-dev/glass
1 participant
@paddyroddy