Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: qlinear conv #591

Merged
merged 2 commits into from
Apr 21, 2024
Merged

Conversation

chachaleo
Copy link
Contributor

Pull Request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior:

Issue Number: #128

I have done the implementation in a similar way than the rest of the quantization operator and I have a small error with most of the test I made (max|error| = 1, but it can be a significant error on the type I8). Should I investigate further on this ?

Also, for each quantization operator we have X of quantized type Q and scale and zero point of dequantized type T. On ONNX they have X and zero point of type Q and scale of type T. Is it a choice of implementation or is it something that should be changed to be closer to the ONNX interface ? I can open an issue on filling the gap bitween the ONNX implementation of quantization operators and Orion implementation if you think there is a need for that :)

@raphaelDkhn raphaelDkhn changed the base branch from main to develop April 21, 2024 08:58
Copy link
Collaborator

@raphaelDkhn raphaelDkhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@raphaelDkhn raphaelDkhn merged commit 508c48f into gizatechxyz:develop Apr 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants