Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
What is the current behavior:
Issue Number: #128
I have done the implementation in a similar way than the rest of the quantization operator and I have a small error with most of the test I made (max|error| = 1, but it can be a significant error on the type I8). Should I investigate further on this ?
Also, for each quantization operator we have X of quantized type Q and scale and zero point of dequantized type T. On ONNX they have X and zero point of type Q and scale of type T. Is it a choice of implementation or is it something that should be changed to be closer to the ONNX interface ? I can open an issue on filling the gap bitween the ONNX implementation of quantization operators and Orion implementation if you think there is a need for that :)