Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create image for python 3.11 and remove EOL python 3.6 #1003

Merged
merged 2 commits into from
Dec 30, 2022
Merged

Create image for python 3.11 and remove EOL python 3.6 #1003

merged 2 commits into from
Dec 30, 2022

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Dec 30, 2022

Description

Create image for python 3.11

Related Issue(s)

Fixes #993

How to test

  • Open workspace
  • ./build-combo.sh python-3.11
  • docker run --rm -it localhost:5000/dazzle:python-3.11 sh
  • python --version

Release Notes

Create image for python 3.11

@Furisto Furisto self-assigned this Dec 30, 2022
@Furisto Furisto requested a review from a team December 30, 2022 11:20
kylos101
kylos101 reviewed Dec 30, 2022
View reviewed changes
Copy link
Collaborator

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Furisto may I ask you to also remove 3.6? It is now EOL.

It'll still live on in Docker Hub, but, we'll stop updating the combination. This'll also help preventing the build time from increasing by running one more combination.

@gitpod-io
Copy link

gitpod-io bot commented Dec 30, 2022

@kylos101 kylos101 changed the title Create image for python 3.11 Create image for python 3.11 and remove EOL python 3.6 Dec 30, 2022
@Furisto
Copy link
Member Author

Furisto commented Dec 30, 2022

@kylos101 PTAL

kylos101
kylos101 approved these changes Dec 30, 2022
View reviewed changes
Copy link
Collaborator

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Furisto !

@kylos101 kylos101 merged commit bce5124 into main Dec 30, 2022
@kylos101 kylos101 deleted the fo/python-3.11 branch December 30, 2022 16:04
@kylos101
Copy link
Collaborator

For posterity, we haven't updated 3.6 in seven months. https://hub.docker.com/r/gitpod/workspace-python-3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylos101 kylos101 kylos101 approved these changes

Assignees

@Furisto Furisto

Labels
team: workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[python] Add gitpod/workspace-python-3.11
2 participants
@Furisto @kylos101