Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JetBrains] display workspace name on the navbar #20544

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Jan 24, 2025

Description

Related Issue(s)

Fixes CLC-1079

How to test

Note

There's a limitation: getHostnameShort is only called one time by JetBrains on the editor start, so we can't update the NavBar when user updates workspace name. Only after they restart the workspace, the title on NavBar could change

  • Open a workspace on preview env with IntelliJ
  • Rename the workspace and restart workspace
  • It should show the name on the NavBar
image

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@mustard-mh mustard-mh changed the title [JetBrains] display workspace name on the remote navbar [JetBrains] display workspace name on the navbar Jan 24, 2025
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and changes work as advertised. Thank you!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants