Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#185 Update Linux install script to refer to the correct relative paths #186

Conversation

brunofin
Copy link
Contributor

@brunofin brunofin commented Feb 2, 2024

Modify script so it works with the instructions provided in README.

Closes #185

Copy link

@barnett-yuxiang barnett-yuxiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested it?

@brunofin
Copy link
Contributor Author

brunofin commented Feb 2, 2024

@barnett-yuxiang yes. When I originally wrote the linux install scripts, the instructions I provided in the README.md file were considering running the script from the root of the repository: 29880d5

Since then, it seems the instructions for both Mac and Linux have changed to first cd into the utils folder and run the script from there. Whoever did those changes also changed the mac os install script to refer to the parent path with .. but did not update the linux install scripts. That's what this PR is doing.

@Finii
Copy link
Contributor

Finii commented Feb 2, 2024

There are multiple PRs that fix the same thing. Ever looked through open PRs?

For example

@idan idan added this to the 1.101 milestone May 9, 2024
@idan
Copy link
Contributor

idan commented May 9, 2024

Fixed in the batch of commits around 93c4bcd. Thank you!

@idan idan closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Linux install script not working due to wrong reference to ./fonts instead of ../fonts etc
4 participants