Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added egui #3976

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Added egui #3976

merged 2 commits into from
Oct 17, 2023

Conversation

gorentbarak
Copy link
Contributor

@gorentbarak gorentbarak commented Oct 9, 2023

Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
  • Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

  • I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
  • My folder contains a *.png image (if applicable) and index.md
  • All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

  • My suggested edits are not about an existing topic or collection, or at least not a single one
  • My suggested edits are not about curating a new topic or collection, or at least not a single one
  • My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.


Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@gorentbarak gorentbarak requested a review from a team as a code owner October 9, 2023 17:19
@ipc103
Copy link
Contributor

ipc103 commented Oct 11, 2023

👋 Hi, thanks for the contribution. Can you please add and fill out the Pull Request template for this PR? You can look at another open PR for an example. We require this to be filled out before reviewing/approving/merging.

@ahpook
Copy link
Contributor

ahpook commented Oct 13, 2023

@gorentbarak I updated your top comment with an empty PR template, please edit it to indicate the requested information so we can merge the PR.

@gorentbarak
Copy link
Contributor Author

@ahpook Great! I filled it in.

Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ahpook ahpook enabled auto-merge October 16, 2023 21:58
auto-merge was automatically disabled October 16, 2023 22:43

Head branch was pushed to by a user without write access

@gorentbarak
Copy link
Contributor Author

@ahpook I didn't fill in the topic field before, can you re-enable auto-merge?

@ahpook ahpook enabled auto-merge October 16, 2023 22:46
@ahpook ahpook disabled auto-merge October 17, 2023 00:33
@ahpook ahpook merged commit a0330c3 into github:main Oct 17, 2023
@ahpook
Copy link
Contributor

ahpook commented Oct 17, 2023

I'll fix the description so tests pass after this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants