Fix GitHub sign in with a browser #1160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of September 8 2021 github removed API authentication through query parameters - https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/
This was referenced Jan 13, 2022
Closed
LukasKristensen
approved these changes
Feb 16, 2022
|
I just had to dig through several issue threads and find the instructions on how to apply this fix myself. It's been over half a year and this basic functionality is still busted. Please fix this already. |
|
Can we get this merged and a patch release cut? |
Nightcaat
approved these changes
Nov 29, 2022
harshitverma209
approved these changes
Jan 22, 2023
|
I can confirm that this bug is still present, and this fix works. Please merge. |
|
I can also confirm that this bug is still present and that applying this fixes it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of September 8 2021 github removed API authentication through query parameters - https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/
Requirements
Description of the Change
As of September 8 2021 github removed API authentication through query parameters - https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/ .
Changing to auth via "Authorization: token ..." header.
Alternate Designs
Benefits
Possible Drawbacks
Applicable Issues