Package Manager package support, .net 4, Unity 2019, Git for Unity, and more #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for-Unity https://github.com/spoiledcat/Git-for-Unity is now the authoritative source for Git for Unity, so we only need to build the UI bits on top of that library. Most of the work for Git for Unity happens at the https://github.com/Unity-Technologies/Git-for-Unity fork, and the spoiledcat/Git-for-Unity master repo is for hosting lfs, tracking stable branches, and so I can actually have control over who does what on it.
Yes, this is a big one.
This was referenced Aug 13, 2019
|
Any ETA when this will be merged to master? I'm in the process of upgrading. Thxs :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large refactor to reuse the api source in https://github.com/Unity-Technologies/Git-for-Unity (via a fork in https://github.com/spoiled/Git-for-Unity), so this repo will only concern itself with building the UI.
It also changes the build system to output Package Manager packages, with .net 35 (for Unity 5.6 and above targeting the .net 2.0 profile), and .net 471 (for 2018+ targeting the .net 4 profile). Because there's so many changes to how things are packaged, there's no longer a loader trying to guess which DLLs to load/unload based on the active profile. Instead, there are separate packages for each profile.
This also indirectly switches to using dugite git packages on all platforms, and adds asmdef to all projects.
Fixes #1070 #1068 #1053 #1018 #962 #456