Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UPM package distribution option #962

Closed
tlaedre opened this issue Nov 12, 2018 · 8 comments
Closed

Add UPM package distribution option #962

tlaedre opened this issue Nov 12, 2018 · 8 comments
Labels

Comments

@tlaedre
Copy link

tlaedre commented Nov 12, 2018

It would be great if there was a distribution option to get Github4Unity as a upm package. There's no real reason for the tool to live inside the Assets/ folder.

@tlaedre tlaedre changed the title Add UPM package distribution option [feature requesst] Add UPM package distribution option Nov 12, 2018
@tlaedre tlaedre changed the title [feature requesst] Add UPM package distribution option [feature request] Add UPM package distribution option Nov 12, 2018
@nickserv
Copy link

It's also confusing to have the plugin itself show up in changes, it has a lot of binary files that you wouldn't normally want to commit.

@StanleyGoldman StanleyGoldman changed the title [feature request] Add UPM package distribution option Add UPM package distribution option Nov 26, 2018
@StanleyGoldman
Copy link
Member

Hey @tlaedre @nickmccurdy thanks for letting us know what you need. Ultimately this is a direction we would like to explore, but we don't have any immediate plans to start with it.

@nickmccurdy I agree it's confusing, but it shouldn't constantly be showing changes, only after an update or when changing versions of Unity. Is that what you are seeing?

@nickserv
Copy link

I recently reinstalled Unity to get the latest version and then installed the GitHub extension, and it shows up in changes every time I launch this Unity project.

@StanleyGoldman
Copy link
Member

You should be free to commit the changes, that is the intention.
It shouldn't show up again after you commit it.

@JoNax97
Copy link

JoNax97 commented Jun 29, 2019

Hey there!
I'm going through the process of moving GithubForUnity to a package, for personal use. I would like to commit it when it's ready, but I have a few questions:

1- Would com.github.unity be the right package name?
2- Should the UPM version live along with the Assets folder version? Or may it become a replacement going forward?
3- I have modified ExtensionLoader to support loading from packages folder, but the logic for it is currently driven by a const. Is this fine or should it be sorted at runtime?
4- Is there any potential issue I should look into?

@shana
Copy link
Member

shana commented Jul 2, 2019

@JoNax97 Hey! This work is already underway at https://github.com/Unity-Technologies/Git-for-Unity, and I'm planning on porting that back here this week. If you want to try it out, the master branch over there is already usable as a package, you can try the sample project in the UnityProject folder to see how it works.

@shana
Copy link
Member

shana commented Aug 13, 2019

#1070 has all the changes needed for this, early builds are available in https://ci.appveyor.com/project/shana/git-for-unity

@shana
Copy link
Member

shana commented Oct 19, 2022

This project is not maintained anymore. The replacement is Git for Unity, at https://github.com/spoiledcat/git-for-unity. If you have GitHub for Unity in your project, remove it first and then install the Git for Unity package, see the README in the link for instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants