This repository has been archived by the owner on May 2, 2024. It is now read-only.
Add env to spawn #53
Merged
Add env to spawn #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffrafter
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Thank you so much for this change 😍 This looks good to me and I've approved it - but I should note that I am not at GitHub and don't have the rights to merge this change moving forward. Tagging @JessRudder who is awesome and might have the power.
ashishkeshan
approved these changes
Sep 12, 2023
|
👋 @zrdaley and @ashishkeshan - you are awesome for merging so many PRs! Just wanted to confirm this is still approved in my book if that counts for anything 🎈 |
jeffrafter
approved these changes
Sep 15, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when child processes are spawned, access to environment variables is very limited. This results in a number of languages being unable to run. Notably:
This PR adds the following env to child process spawning:
DOTNET_CLI_HOMEset to/tmpDOTNET_NOLOGOto suppress welcome messageHOMEcopied from parent process. This is needed for Go lang.