Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [BUG] Overflow of quotes content for large quotes in mobile view. #247

Merged
merged 6 commits into from
Mar 28, 2024

Conversation

ankitaniket
Copy link
Contributor

Hare Krishna!

Summary of Changes

This pull request addresses the issues mentioned in #216 regarding the overflow of quote content for large quotes in mobile view.

I have also enhanced QuotesNavigator: Added bg-white to buttons during scroll, maintained it for 3 seconds after scroll stops, and removed the background when idle.

Video Demonstration

Watch the video demonstration here

Please Review

I welcome your feedback and review of these enhancements.

Copy link

vercel bot commented Mar 5, 2024

@ankitaniket is attempting to deploy a commit to the Gita-v2 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gita-frontend-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 0:19am

@samanyougarg
Copy link
Member

Hare Krishna, thanks for making the PR.

https://www.loom.com/share/2041608bf62c42c78a54a7ad56eeef67

There are a couple of improvements needed:

  1. With this fix, the arrows on desktop don't stay fixed on scroll due to which the arrows are showing up on the footer on scrolling.
  2. On clicking the next button, the height of the page is adjusting and there's a bounce effect which is not very stable.
  3. The padding above the quote should be equal to the padding below so it is center aligned.

@samanyougarg
Copy link
Member

Hare Krishna, please see the buttons are overlapping with the text on mobile.

CleanShot 2024-03-28 at 14 22 35@2x

@ankitaniket
Copy link
Contributor Author

Radhey Radhey prabhuji !
Thank you for your review
I have adjusted the buttons to be at the top for the mobile view. Please take a moment to review the changes.

@samanyougarg samanyougarg merged commit a23bff5 into gita:main Mar 28, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants