Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Chapter page issues #188 #245

Merged
merged 4 commits into from
Mar 3, 2024
Merged

[BUG] Chapter page issues #188 #245

merged 4 commits into from
Mar 3, 2024

Conversation

ankitaniket
Copy link
Contributor

Summary of Changes

This pull request addresses the issues mentioned in #188 related to the chapter page.

The key improvements include:

  • Adjustment of the verse selection dropdown size.
  • Proper alignment of verse numbers to eliminate excess space.
  • Implementation of closing the dropdown by clicking outside the box.
  • Direct navigation to a verse page by clicking on its number.

Screenshots

Issue188

Please Review

Your feedback and review on these changes would be greatly appreciated.

Copy link

vercel bot commented Mar 2, 2024

@ankitaniket is attempting to deploy a commit to the Gita-v2 Team on Vercel.

A member of the Team first needs to authorize it.

@samanyougarg
Copy link
Member

Hare Krishna!
Thanks for submitting the PR. It looks good overall.

2 issues:
https://www.loom.com/share/08a39b0f61a347a39741e3610ba02919

  1. There is a flickering happening when hovering over the verse numbers.
  2. On clicking a verse, it is opening the verse page as per requirement but for <1 seconds, it shows the filtered verse on the same page first. This should instantly open the verse page.

@samanyougarg
Copy link
Member

Also, for mobile, earlier one was better since the click area for each verse number was a bit more.
CleanShot 2024-03-02 at 23 49 50@2x

@ankitaniket
Copy link
Contributor Author

Hare Krishna
Thank you for bringing these issues to my attention. I've made the necessary adjustments to address them:

  • Resolved the flickering issue.
  • Eliminated the occurrence of filtering verses on the same page before navigating.
  • Retained the earlier UI for mobile view, as it provided a better click area for each verse number.
  • Increased the width for verseCount greater than 50, ensuring consistency for both mobile and desktop views.

Your feedback is valuable, and I appreciate your time in reviewing the proposed changes.

@samanyougarg
Copy link
Member

Hare Krishna, thanks for resolving those issues.

Please see the margin on the left side here.
CleanShot 2024-03-03 at 12 43 39@2x

@samanyougarg
Copy link
Member

On mobile, center alignment of the verses is not optimal. We should keep it left aligned.

CleanShot 2024-03-03 at 12 45 10@2x

@ankitaniket
Copy link
Contributor Author

Hare Krishna!
Thanks for the suggestion. I have applied margin and left alignment for mobile devices. Please review it once.

https://www.loom.com/share/afed89b549ef4b7a92c4b9114397b99f?sid=4c0dab9f-27d5-4646-8885-682f6f682647

@samanyougarg samanyougarg merged commit 84fd142 into gita:main Mar 3, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants