Sk/bug188 chapter page

[sarthak-kumar-shailendra]

Resolving bug - 188
#188 reported by @samanyougarg

1. Reduced verse selection dropdown size on chapter page.
2. Resolved spacing issues of verse numbers and right side extra margin
3. Clicking on verse number directly opens the verse page

[vercel]

@sarthak-kumar-shailendra is attempting to deploy a commit to the Ved Vyas Foundation Team on Vercel.

A member of the Team first needs to authorize it.

[samanyougarg]

Thanks for picking up this PR @sarthak-kumar-shailendra !

[samanyougarg]

Reduced verse selection dropdown size on chapter page.
This is fixed.

[samanyougarg]

Resolved spacing issues of verse numbers and right side extra margin
There are some more issues here. When there are too many shlokas, the dropdown looks weird.

See the gap after 46:

Additionally, the dropdown is becoming too long if there are too many verses. Can we try something else for better UX? Perhaps show the first 4 rows of shlokas and then add a scrollbar?

[samanyougarg]

Clicking on verse number directly opens the verse page
This has been fixed and is working well thank you!

[samanyougarg]

Could you please pick up this one as well:

Clicking outside the verse selection box should close it.

[sarthak-kumar-shailendra]

@samanyougarg will do the required changes

[sarthak-kumar-shailendra]

Have fixed this - "Clicking outside the verse selection box should close it."
Also, have added max height and scroll behaviour to dropdown. However, was not able to repro that gap issue after 46th verse...
@samanyougarg can you check again and let me know the screen dimensions if it's still happening

[sarthak-kumar-shailendra]

@samanyougarg pls check this

[sarthak-kumar-shailendra]

Hare Krishna
pls review @samanyougarg

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
bhagavad-gita	✅ Ready (Inspect)	Visit Preview	Jan 20, 2024 6:19pm

[samanyougarg]

Hare Krishna, the height of this dropdown still needs reduction.

[samanyougarg]

Other things seem good. Once we reduce the height, we can merge. Sorry for the delay here.

[samanyougarg]

Please fix dropdown height.

[sarthak-kumar-shailendra]

Hare Krishna,
I have already reduced the height of the dropdown menu to accommodate the first 4 rows as instructed before. Do you want to make it even shorter or are you asking me to reduce the height of the dropdown CTA? @samanyougarg