Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ai link + changed URL structure #218

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Add ai link + changed URL structure #218

merged 2 commits into from
Sep 7, 2023

Conversation

samanyougarg
Copy link
Member

@samanyougarg samanyougarg commented Sep 7, 2023

Summary by CodeRabbit

  • New Feature: Added a new navigation link "Bhagavad Gita AI" in the footer, which redirects to "https://bhagavadgita.ai" in a new tab.
  • Refactor: Updated URL structure across various pages and components for consistency. Removed trailing slashes from URLs in metadata and JSON-LD data.
  • Refactor: Changed the URL /quotes to /bhagavad-gita-quotes in mobile navigation and IndexHeader component.
  • Chore: Updated Sentry configuration in next.config.js by disabling the logger.

@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bg-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 8:01pm
bhagavad-gita ✅ Ready (Inspect) Visit Preview Sep 7, 2023 8:01pm

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Image description CodeRabbit

Walkthrough

This update primarily focuses on URL structure modifications across various pages and components, removing trailing slashes for consistency. Additionally, it introduces a new navigation link to "Bhagavad Gita AI" and updates the Sentry configuration in next.config.js by disabling the logger.

Changes

File(s) Summary
next.config.js Disabled the logger in the Sentry configuration.
src/app/[[...locale]]/page.tsx, src/app/about/[[...locale]]/page.tsx, src/app/acknowledgements/[[...locale]]/page.tsx, src/app/bhagavad-gita-quotes/[[...locale]]/page.tsx, src/app/chapter/[chapterNumber]/(chapter)/[[...locale]]/page.tsx, src/app/chapter/[chapterNumber]/verse/[verseNumber]/[[...locale]]/page.tsx, src/app/privacy-policy/[[...locale]]/page.tsx Removed trailing slashes from the URL and canonical properties in the metadata of various pages.
src/app/about/[[...locale]]/constants.ts, src/app/acknowledgements/[[...locale]]/constants.ts, src/app/bhagavad-gita-quotes/[[...locale]]/constants.ts, src/app/chapter/[chapterNumber]/(chapter)/[[...locale]]/functions.ts, src/app/chapter/[chapterNumber]/verse/[verseNumber]/[[...locale]]/functions.ts Removed the trailing slash from the "@id" value in the jsonLdTwo object and getJsonLd function.
src/components/Footers/Footer.tsx Added a new navigation link "Bhagavad Gita AI".
src/components/Headers/IndexHeader.tsx Replaced /quotes URL with /bhagavad-gita-quotes in the mobileNav and IndexHeader component.

"In the land of code, where logic is king, 🤴
Changes are made, improvements they bring. 💻
Slashes were dropped, URLs got lean, 🌐
A new link was born, for all to be seen. 👀
Sentry stood silent, its logger at rest, 🕵️‍♂️
Celebrate these changes, for they are the best! 🎉"


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 9c8d6d4 and 5cce4b8 commits.
Files selected (15)
  • next.config.js (2)
  • src/app/[[...locale]]/page.tsx (2)
  • src/app/about/[[...locale]]/constants.ts (1)
  • src/app/about/[[...locale]]/page.tsx (2)
  • src/app/acknowledgements/[[...locale]]/constants.ts (1)
  • src/app/acknowledgements/[[...locale]]/page.tsx (2)
  • src/app/bhagavad-gita-quotes/[[...locale]]/constants.ts (1)
  • src/app/bhagavad-gita-quotes/[[...locale]]/page.tsx (2)
  • src/app/chapter/[chapterNumber]/(chapter)/[[...locale]]/functions.ts (1)
  • src/app/chapter/[chapterNumber]/(chapter)/[[...locale]]/page.tsx (2)
  • src/app/chapter/[chapterNumber]/verse/[verseNumber]/[[...locale]]/functions.ts (1)
  • src/app/chapter/[chapterNumber]/verse/[verseNumber]/[[...locale]]/page.tsx (2)
  • src/app/privacy-policy/[[...locale]]/page.tsx (1)
  • src/components/Footers/Footer.tsx (1)
  • src/components/Headers/IndexHeader.tsx (2)
Files skipped from review due to trivial changes (12)
  • next.config.js
  • src/app/about/[[...locale]]/constants.ts
  • src/app/about/[[...locale]]/page.tsx
  • src/app/acknowledgements/[[...locale]]/page.tsx
  • src/app/bhagavad-gita-quotes/[[...locale]]/constants.ts
  • src/app/bhagavad-gita-quotes/[[...locale]]/page.tsx
  • src/app/chapter/[chapterNumber]/(chapter)/[[...locale]]/functions.ts
  • src/app/chapter/[chapterNumber]/(chapter)/[[...locale]]/page.tsx
  • src/app/chapter/[chapterNumber]/verse/[verseNumber]/[[...locale]]/functions.ts
  • src/app/chapter/[chapterNumber]/verse/[verseNumber]/[[...locale]]/page.tsx
  • src/app/privacy-policy/[[...locale]]/page.tsx
  • src/components/Footers/Footer.tsx
Review comments generated (5)
  • Review: 3
  • LGTM: 2

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@@ -23,7 +23,7 @@ export const jsonLdTwo = {
"@type": "ListItem",
position: 2,
item: {
"@id": "https://bhagavadgita.io/acknowledgements/",
"@id": "https://bhagavadgita.io/acknowledgements",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

The change from a trailing slash to no trailing slash in the URL is fine as long as it's consistent across the application and the server is configured correctly. If the server isn't configured to handle requests without trailing slashes, this could lead to 404 errors. Please ensure that your server is set up to handle this change.

-        "@id": "https://bhagavadgita.io/acknowledgements/",
+        "@id": "https://bhagavadgita.io/acknowledgements",

@@ -109,7 +109,7 @@ const chapters = [
];

const mobileNav = [
{ name: "Quotes", href: "/quotes", current: false },
{ name: "Quotes", href: "/bhagavad-gita-quotes", current: false },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

The change from /quotes to /bhagavad-gita-quotes seems fine as long as the corresponding route handler is updated to handle this new URL. If not, it could lead to a 404 error.

- { name: "Quotes", href: "/quotes", current: false },
+ { name: "Quotes", href: "/bhagavad-gita-quotes", current: false },

@@ -225,7 +225,7 @@
)}
</Popover>
<LinkWithLocale
href="/quotes"
href="/bhagavad-gita-quotes"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Similar to the previous comment, ensure that the route handler is updated to handle the new URL /bhagavad-gita-quotes. Otherwise, users clicking on this link will encounter a 404 error.

- href="/quotes"
+ href="/bhagavad-gita-quotes"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant