improving set_cookie security #392
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
We have a free program analysis tool for Python 3 web projects, called Bento. While we were scanning GitHub projects for issues, it triggered a warning for the set_cookie method on your app. Looks like you use cookies for user settings (not auth) so perhaps it is no big deal. But I don't think it does any harm to secure the cookies (it is 1-line change) and it prevents malicious actors from stealing settings cookies.
There were bunch of other warnings bento triggered on, but I didn't include them in this PR to keep it clean an simple. If you are curious, you can check it out yourself by downloading bento from https://bento.dev/