Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ajout d'une balise youtube dans le markdown #810

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

vincentporte
Copy link
Contributor

@vincentporte vincentporte commented Nov 8, 2024

Description

🎸 Permettre l'ajout d'une video Youtube en iframe, en utilisant une balise de style markdown [youtube:12345abc]

Type de changement

🎢 Nouvelle fonctionnalité (changement non cassant qui ajoute une fonctionnalité).
🚧 technique

Points d'attention

🦺 rationalisation des rendus de champs markdown via le gabarit partials/rendered_md.html
🦺 rationalisation des vues TopicContentView et TopicCertifiedPostView en utilisant directement le nouveau gabarit
🦺 suppression du gabarit post_preview.html (code mort)

@vincentporte vincentporte linked an issue Nov 8, 2024 that may be closed by this pull request
@vincentporte vincentporte self-assigned this Nov 8, 2024
@vincentporte vincentporte changed the title feat(youtube): ajout d'une balise specifique dans le markdown feat: ajout d'une balise youtube dans le markdown Nov 8, 2024
@vincentporte vincentporte force-pushed the 790-video-yt-ajouter-une-syntaxe-markdown branch from 3e87479 to 527ba29 Compare November 8, 2024 16:58
@vincentporte vincentporte marked this pull request as ready for review November 8, 2024 17:00
@vincentporte vincentporte force-pushed the 790-video-yt-ajouter-une-syntaxe-markdown branch from 527ba29 to 0ba7e25 Compare November 8, 2024 17:10
@vincentporte vincentporte added python Pull requests that update Python code templating technical debt labels Nov 8, 2024
@vincentporte vincentporte merged commit adbff17 into master Nov 14, 2024
14 checks passed
@vincentporte vincentporte deleted the 790-video-yt-ajouter-une-syntaxe-markdown branch November 14, 2024 12:55
vincentporte pushed a commit that referenced this pull request Nov 14, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.17.0](v2.16.0...v2.17.0)
(2024-11-14)


### Features

* ajout d'une balise youtube dans le markdown
([#810](#810))
([adbff17](adbff17))
* **forum_conversation:** suppression du triage avant de pouvoir poser
une question
([#818](#818))
([f1b64c6](f1b64c6))
* **stats:** ajout de la colonne categorie dans les stats des fiches
pratiques
([#812](#812))
([c072b5f](c072b5f))
* **user:** authentification via un lien magique envoyé par email
([#804](#804))
([64e04a3](64e04a3))
* **user:** basculer l'authentification vers ProConnect
([#731](#731))
([5429fce](5429fce))


### Bug Fixes

* **attachment:** affichage des liens vers les fichiers des messages
([#806](#806))
([7c34605](7c34605))
* **metabase:** deplanification d'une tâche résiduelle
([#808](#808))
([692a274](692a274))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
vincentporte added a commit that referenced this pull request Nov 14, 2024
vincentporte added a commit that referenced this pull request Nov 14, 2024
## Description

🎸 log pollution because of a print in `youtube_embed`

## Type de changement

🪲 Correction de bug (changement non cassant qui corrige un problème).
🚧 technique
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code technical debt templating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Video YT] ajouter une syntaxe markdown
1 participant