Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVENEMENT] restaurer les evenements sans javascript #433

Merged
merged 8 commits into from
Oct 2, 2023

Conversation

vincentporte
Copy link
Contributor

@vincentporte vincentporte commented Sep 27, 2023

Description

🎸 acceder à la liste mensuelle des evenements sans mise en forme JS
🎸 naviguer mois par mois
🎸 accès au détail d'un évènement

Type de changement

🪲 Correction de bug (changement non cassant qui corrige un problème).
🚧 technique

Points d'attention

🦺 sans js pour résoudre le problème de CSP
🦺 suppression des composants /static/vender/tiva-calendar et de la génération de données au format json pour alimenter ce calendrier

Captures d'écran (optionnel)

Vue mensuelle

image

Vue de détail

image

@vincentporte vincentporte self-assigned this Sep 27, 2023
@vincentporte vincentporte added hot fix Pull requests that fix a bug to fix as soon as possible python Pull requests that update Python code labels Sep 27, 2023
lacommunaute/templates/partials/footer.html Outdated Show resolved Hide resolved
lacommunaute/templates/event/event_month_list.html Outdated Show resolved Hide resolved
lacommunaute/templates/event/event_month_list.html Outdated Show resolved Hide resolved
lacommunaute/templates/event/event_detail.html Outdated Show resolved Hide resolved
lacommunaute/event/views.py Outdated Show resolved Hide resolved
lacommunaute/templates/event/event_month_list.html Outdated Show resolved Hide resolved
@vincentporte vincentporte force-pushed the vincentporte/quick_calendar_restore branch 3 times, most recently from df3b1e7 to 8918191 Compare October 2, 2023 10:04
@vincentporte vincentporte marked this pull request as ready for review October 2, 2023 10:16
Copy link

@xavfernandez xavfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top d'avoir supprimé la lib JS 👍

lacommunaute/event/views.py Outdated Show resolved Hide resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je suis étonné que vous commitiez vos fichiers mo.
J'ai plus l'habitude de ne garder que les po et lancer un compilemessages avant le déploiement 🤷‍♂️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci, je note pour une amélio tech prochaine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lacommunaute/templates/event/event_detail.html Outdated Show resolved Hide resolved
Copy link

@vperron vperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas grand chose à dire ! OK avec xavier. Potentiellement voir avec le métier si on veut garder les traductions à terme ?

@@ -941,6 +947,9 @@ msgstr "Ajouter un évènement public"
msgid "Delete event"
msgstr "Effacer cet évènement"

msgid "Back to events list"
msgstr "Retourner à la liste des évènements"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Les Emplois en entier n'est pas traduit. Pourquoi la communauté le serait ? Je pose la question parce que c'est une TANNEE a maintenir ^^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est hérité de django-machina ^^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn ...

lacommunaute/templates/event/event_detail.html Outdated Show resolved Hide resolved
@vincentporte vincentporte force-pushed the vincentporte/quick_calendar_restore branch from 8918191 to cd5d8b4 Compare October 2, 2023 15:54
@vincentporte vincentporte merged commit 866cc91 into master Oct 2, 2023
4 checks passed
@vincentporte vincentporte deleted the vincentporte/quick_calendar_restore branch October 2, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot fix Pull requests that fix a bug to fix as soon as possible python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants