add workspace for intermediate vector in and adapt apply_uses_initial_guess in Schwarz
#1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:testing
MarcelKoch
requested changes
Oct 9, 2024
| }, | ||
| alpha, b, beta, x); | ||
| } | ||
|
|
||
|
|
||
| template <typename ValueType, typename LocalIndexType, typename GlobalIndexType> | ||
| template <typename VectorType> | ||
| void Schwarz<ValueType, LocalIndexType, GlobalIndexType>::set_cache_to( |
There was a problem hiding this comment.
You only need this function once, right? Then I would prefer to just add this directly, it's not that much IMO.
| * (could also be done with writing `operator=` and copy | ||
| * constructor of the enclosing class by hand) | ||
| */ | ||
| mutable struct cache_struct { |
There was a problem hiding this comment.
I think this should be a DenseCache instead.
There was a problem hiding this comment.
I think it does not support distributed::Vector.
There was a problem hiding this comment.
you're right. Perhaps it would make sense to add VectorCache, instead of using the cache construct.
pratikvn
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a cache/workspace for the intermediate vector in advanced_apply of Schwarz.
Also, it makes apply_uses_initial_guess rely on the
local_solver->apply_uses_initial_guess().We might need to revisit this function after adding refining step in Schwarz.