Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/read/abbrev.rs: Mark mod tests as pub(crate) #694

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

Enselic
Copy link
Contributor

@Enselic Enselic commented Jan 30, 2024

Fixes "warning: private item shadows public glob re-export" when doing "cargo test". Before the fix, the warning looks like this:

warning: private item shadows public glob re-export
   --> src/read/mod.rs:681:1
    |
681 | / mod tests {
682 | |     use super::*;
683 | |     use crate::common::Format;
684 | |     use crate::endianity::LittleEndian;
...   |
826 | |     }
827 | | }
    | |_^
    |
note: the name `tests` in the type namespace is supposed to be publicly re-exported here
   --> src/read/mod.rs:208:9
    |
208 | pub use self::abbrev::*;
    |         ^^^^^^^^^^^^^^^
note: but the private item here shadows it
   --> src/read/mod.rs:681:1
    |
681 | / mod tests {
682 | |     use super::*;
683 | |     use crate::common::Format;
684 | |     use crate::endianity::LittleEndian;
...   |
826 | |     }
827 | | }
    | |_^
    = note: `#[warn(hidden_glob_reexports)]` on by default

With the fix, there is no warning.

Fixes "warning: private item shadows public glob re-export" when doing
"cargo test".

warning: private item shadows public glob re-export
   --> src/read/mod.rs:681:1
    |
681 | / mod tests {
682 | |     use super::*;
683 | |     use crate::common::Format;
684 | |     use crate::endianity::LittleEndian;
...   |
826 | |     }
827 | | }
    | |_^
    |
note: the name `tests` in the type namespace is supposed to be publicly re-exported here
   --> src/read/mod.rs:208:9
    |
208 | pub use self::abbrev::*;
    |         ^^^^^^^^^^^^^^^
note: but the private item here shadows it
   --> src/read/mod.rs:681:1
    |
681 | / mod tests {
682 | |     use super::*;
683 | |     use crate::common::Format;
684 | |     use crate::endianity::LittleEndian;
...   |
826 | |     }
827 | | }
    | |_^
    = note: `#[warn(hidden_glob_reexports)]` on by default
@philipc philipc merged commit c6490b3 into gimli-rs:master Jan 31, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants