Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fetching UUIDs from macho libs #13

Merged
merged 4 commits into from
Apr 10, 2018

Conversation

mitsuhiko
Copy link
Contributor

We actually only ever use the UUID for symbolication but the library so far does not expose it. I made this generic so that later build notes from Elf can also be supported. It also does not add a dependency to the UUID crate but instead just exposes a [u8; 16].

@mitsuhiko
Copy link
Contributor Author

The test failure is related to ! stabilization which is being reverted: rust-lang/rust#49691

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks!

@fitzgen fitzgen merged commit d8bf4cb into gimli-rs:master Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants