Skip to content

Commit

Permalink
Keep dependencies at end of parameter list
Browse files Browse the repository at this point in the history
  • Loading branch information
dmhts committed Sep 25, 2024
1 parent 3ca0227 commit eaa8f2c
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
6 changes: 3 additions & 3 deletions Sources/ScipioKit/Producer/FrameworkProducer.swift
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,17 @@ struct FrameworkProducer {
cacheMode: Runner.Options.CacheMode,
overwrite: Bool,
outputDir: URL,
fileSystem: any FileSystem = localFileSystem,
toolchainEnvironment: [String: String]? = nil
toolchainEnvironment: [String: String]? = nil,
fileSystem: any FileSystem = localFileSystem
) {
self.descriptionPackage = descriptionPackage
self.baseBuildOptions = buildOptions
self.buildOptionsMatrix = buildOptionsMatrix
self.cacheMode = cacheMode
self.overwrite = overwrite
self.outputDir = outputDir
self.fileSystem = fileSystem
self.toolchainEnvironment = toolchainEnvironment
self.fileSystem = fileSystem
}

func produce() async throws {
Expand Down
6 changes: 3 additions & 3 deletions Sources/ScipioKit/Producer/PIF/PIFCompiler.swift
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,17 @@ struct PIFCompiler: Compiler {
descriptionPackage: DescriptionPackage,
buildOptions: BuildOptions,
buildOptionsMatrix: [String: BuildOptions],
toolchainEnvironment: [String: String]? = nil,
fileSystem: any FileSystem = TSCBasic.localFileSystem,
executor: any Executor = ProcessExecutor(),
toolchainEnvironment: [String: String]? = nil
executor: any Executor = ProcessExecutor()
) {
self.descriptionPackage = descriptionPackage
self.buildOptions = buildOptions
self.buildOptionsMatrix = buildOptionsMatrix
self.toolchainEnvironment = toolchainEnvironment
self.fileSystem = fileSystem
self.executor = executor
self.buildParametersGenerator = .init(buildOptions: buildOptions, fileSystem: fileSystem)
self.toolchainEnvironment = toolchainEnvironment
}

private func fetchDefaultToolchainBinPath() async throws -> AbsolutePath {
Expand Down
8 changes: 4 additions & 4 deletions Sources/ScipioKit/Producer/PIF/ToolchainGenerator.swift
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,17 @@ import struct Basics.Triple

struct ToolchainGenerator {
private let toolchainDirPath: AbsolutePath
private let executor: any Executor
private let environment: [String: String]?
private let executor: any Executor

init(
toolchainDirPath: AbsolutePath,
executor: any Executor = ProcessExecutor(),
environment: [String: String]? = nil
environment: [String: String]? = nil,
executor: any Executor = ProcessExecutor()
) {
self.toolchainDirPath = toolchainDirPath
self.executor = executor
self.environment = environment
self.executor = executor
}

func makeToolChain(sdk: SDK) async throws -> UserToolchain {
Expand Down

0 comments on commit eaa8f2c

Please sign in to comment.