Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash occurs when launching Minecraft with the Oritech mod. #40

Open
tbouvencourt opened this issue Dec 10, 2024 · 1 comment
Open

Crash occurs when launching Minecraft with the Oritech mod. #40

tbouvencourt opened this issue Dec 10, 2024 · 1 comment

Comments

@tbouvencourt
Copy link

Issue Description

This issue is identical to: Rearth/Oritech Issue #198.
Steps to Reproduce

Download and add Oritech to Profile 1.
Download JsonThings (ensuring it uses the same mod loader: NeoForge).
Launch Minecraft.

Minecraft Version

1.21.1 (Latest)
Platform

NeoForge

@gigaherz
Copy link
Owner

gigaherz commented Dec 10, 2024

My mod injects a new pack type along with its corresponding resource manager, for the purposes of loading the "thingpacks". This pack type gets processed early (before neoforge registry stuffs) and this occasionally trips up mods that assume things about resources (eg doing if data {} else {}, and assuming the else is client resources, or vice versa).

The log you sent on the Oritech issue tracker shows only fabric_resource_loader, so I can't tell if this is an incompatibility between Json Things and this fabric resource loader component, or Oritech is the one requesting the recipe manager. I cannot fix this from Json Things' end, because the entire design of the mod relies on it and I do not intend to change the design. The only possibility would be fore this incompatibility to be fixed on the other end, be it Oritech or the fabric resource loader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants