Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on launch when Jsonthings is installed due to fabric-resource loader #180

Closed
Rearth opened this issue Dec 17, 2024 · 0 comments
Closed

Comments

@Rearth
Copy link

Rearth commented Dec 17, 2024

This is based on the issue that was raised for Oritech here: Rearth/Oritech#198
and JsonThings here: gigaherz/JsonThings#40
It seems that when FFAPI is loaded together with jsonthings, the game refuses to start.

Issue description
If Jsonthings is installed the game crashes on launch.
Steps to reproduce
Run the game with Jsonthings installed. https://www.curseforge.com/minecraft/mc-mods/json-things
Minecraft version
1.21.1 (Latest)
Platform
Neoforge
Loader version
21.1.83
Fabric API version
forgified-fabric-api-0.104.0+2.0.19+1.21.1
Oritech version
oritech-neoforge-0.12.3
Other relevant versions
JsonThings-1.21-0.13.0.jar
If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)
https://pastebin.com/3cLqhYzd

More from the jsonthings dev here:

My mod injects a new pack type along with its corresponding resource manager, for the purposes of loading the "thingpacks". This pack type gets processed early (before neoforge registry stuffs) and this occasionally trips up mods that assume things about resources (eg doing if data {} else {}, and assuming the else is client resources, or vice versa).
The log you sent on the Oritech issue tracker shows only fabric_resource_loader, so I can't tell if this is an incompatibility between Json Things and this fabric resource loader component, or Oritech is the one requesting the recipe manager. I cannot fix this from Json Things' end, because the entire design of the mod relies on it and I do not intend to change the design. The only possibility would be fore this incompatibility to be fixed on the other end, be it Oritech or the fabric resource loader.

I know very little about resource loading, but the issue seems to be pointing to either JsonThings or FFAPI fabric-resource-loader, so I hope it's okay to just move this issue to here

@Su5eD Su5eD closed this as completed in 4ea8954 Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant